Skip to content

feat: add measurement for stops#15

Open
Minipada wants to merge 1 commit into
humblefrom
stops-measurement
Open

feat: add measurement for stops#15
Minipada wants to merge 1 commit into
humblefrom
stops-measurement

Conversation

@Minipada

Copy link
Copy Markdown
Owner

Initial discussions

  • Github issue:

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Test (add, remove, modify test(s))
  • Other

What I did

add a measurement for stops

How I did it

Check when the robot stops and count time it is stopped

I am not sure about

How I tested

By running qr codes simulation

I'm not a dummy, so I've checked these

  • 📑 I documented correctly following our guidelines
  • 💯 I tested locally and it is working
  • 🟢 My code does not fail neither code linting checks nor unit test.

Thank you!

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #15 (451c0fe) into humble (957233e) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           humble      #15      +/-   ##
==========================================
- Coverage   11.44%   11.23%   -0.21%     
==========================================
  Files          66       67       +1     
  Lines        3578     3645      +67     
==========================================
  Hits          409      409              
- Misses       3169     3236      +67     
Impacted Files Coverage Δ
dc_measurements/plugins/measurements/stops.cpp 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants